You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "donnerpeter (via GitHub)" <gi...@apache.org> on 2023/07/28 16:42:03 UTC

[GitHub] [lucene] donnerpeter opened a new pull request, #12468: hunspell: check for aff file wellformedness more strictly

donnerpeter opened a new pull request, #12468:
URL: https://github.com/apache/lucene/pull/12468

   ### Description
   
   <!--
   If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] donnerpeter merged pull request #12468: hunspell: check for aff file wellformedness more strictly

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter merged PR #12468:
URL: https://github.com/apache/lucene/pull/12468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] donnerpeter commented on a diff in pull request #12468: hunspell: check for aff file wellformedness more strictly

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter commented on code in PR #12468:
URL: https://github.com/apache/lucene/pull/12468#discussion_r1277778738


##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java:
##########
@@ -74,7 +74,12 @@ static Dictionary loadDictionary(Path aff) throws IOException, ParseException {
     try (InputStream dictionary = Files.newInputStream(dic);
         InputStream affix = Files.newInputStream(aff);
         BaseDirectoryWrapper tempDir = newDirectory()) {
-      return new Dictionary(tempDir, "dictionary", affix, dictionary);
+      return new Dictionary(tempDir, "dictionary", affix, dictionary) {
+        @Override
+        protected boolean tolerateAffixRuleCountMismatches() {
+          return true;

Review Comment:
   Some checked dictionaries contain rule count mismatches :(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org