[GitHub] [spark] Ngone51 commented on a diff in pull request #37648: [WIP][SPARK-38909][BUILD][CORE][YARN][FOLLOWUP]

[GitBox <gi...@apache.org>]

Ngone51 commented on code in PR #37648:
URL: https://github.com/apache/spark/pull/37648#discussion_r955680841


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java:
##########
@@ -125,15 +125,17 @@ public ShuffleIndexInformation load(String filePath) throws IOException {
       .weigher((Weigher<String, ShuffleIndexInformation>)
         (filePath, indexInfo) -> indexInfo.getRetainedMemorySize())
       .build(indexCacheLoader);
-    DBBackend dbBackend = null;
+    DBBackend dbBackend;
     if (registeredExecutorFile != null) {

Review Comment:
   Do we really need this condition? I feel like it's useless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org