You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 10:30:40 UTC
[GitHub] [apisix] spacewander opened a new pull request #3519: fix(zipkin): always delivery x-b3-sampled header
spacewander opened a new pull request #3519:
URL: https://github.com/apache/apisix/pull/3519
According to
https://github.com/openzipkin/b3-propagation#sampling-state:
> sampling applies consistently per-trace: once the sampling decision is
made, the same value should be consistently sent downstream
We should pass the right x-b3-sampled according to our decision.
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3519: fix(zipkin): always delivery x-b3-sampled header
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #3519:
URL: https://github.com/apache/apisix/pull/3519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3519: fix(zipkin): always delivery x-b3-sampled header
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #3519:
URL: https://github.com/apache/apisix/pull/3519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org