[GitHub] [ozone] ChenSammi commented on a diff in pull request #4030: HDDS-7578. Correct usage of SCM snapshot directory

[GitBox <gi...@apache.org>]

ChenSammi commented on code in PR #4030:
URL: https://github.com/apache/ozone/pull/4030#discussion_r1067765173


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java:
##########
@@ -146,7 +146,7 @@ public static String getSCMRatisDirectory(ConfigurationSource conf) {
 
   public static String getSCMRatisSnapshotDirectory(ConfigurationSource conf) {
     String snapshotDir =
-            conf.get(ScmConfigKeys.OZONE_SCM_HA_RATIS_STORAGE_DIR);
+            conf.get(ScmConfigKeys.OZONE_SCM_HA_RATIS_SNAPSHOT_DIR);

Review Comment:
   I think this snapshot directory acts like a tmp directory.  Every file downloaded from leader SCM to this directory, will be used to replace current SCM's rocksdb. So basically change it from  OZONE_SCM_HA_RATIS_STORAGE_DIR to OZONE_SCM_HA_RATIS_SNAPSHOT_DIR will not cause any compatibility issue, since the files left in this snapshot directory are not useful anymore after a service upgrade restart. 
   
   @nandakumar131,  please correct me if I'm wrong.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org