[GitHub] [iceberg] samarthjain commented on a change in pull request #2091: Spark - Fix parquet vectorized reads when column types are promoted

[GitBox <gi...@apache.org>]

samarthjain commented on a change in pull request #2091:
URL: https://github.com/apache/iceberg/pull/2091#discussion_r558698866



##########
File path: spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
##########
@@ -267,11 +267,23 @@ private static void assertEqualsUnsafe(Type type, Object expected, Object actual
     }
 
     switch (type.typeId()) {
-      case BOOLEAN:
       case INTEGER:
+        Assert.assertEquals("Values didn't match", ((Number) expected).intValue(),
+                ((Number) actual).intValue());

Review comment:
       Without this change, the comparison fails with ClassCastException.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org