You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Li Zhiming (Code Review)" <ge...@cloudera.org> on 2021/05/06 06:27:57 UTC
[kudu-CR] KUDU-3273: check result of TableLocationsCache.get() for null
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17288
to look at the new patch set (#6).
Change subject: KUDU-3273: check result of TableLocationsCache.get() for null
......................................................................
KUDU-3273: check result of TableLocationsCache.get() for null
For TableLocationsCache, if get(key) is called immediately after
cacheTabletLocations(key), it should not return null.
But if partitions change and a call to cacheTabletLocations(otherKey)
occurs between calls to cacheTableLocations(key) and get(key),
the latter might return null.
Change-Id: I13475701804ea4ae2bf8089a1e2b9143a12d2ab9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
4 files changed, 60 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/17288/6
--
To view, visit http://gerrit.cloudera.org:8080/17288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13475701804ea4ae2bf8089a1e2b9143a12d2ab9
Gerrit-Change-Number: 17288
Gerrit-PatchSet: 6
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)