[GitHub] [airflow] josh-fell commented on a diff in pull request #24931: Apply flake8-logging-format changes to tests

[GitBox <gi...@apache.org>]

josh-fell commented on code in PR #24931:
URL: https://github.com/apache/airflow/pull/24931#discussion_r936179220


##########
tests/providers/google/cloud/utils/gcp_authenticator.py:
##########
@@ -107,8 +107,8 @@ def set_key_path_in_airflow_connection(self):
             extras[PROJECT_EXTRA] = self.project_extra if self.project_extra else self.project_id
             conn.extra = json.dumps(extras)
             session.commit()
-        except BaseException as ex:
-            self.log.error('Airflow DB Session error: %s', str(ex))
+        except BaseException:
+            self.log.error('Airflow DB Session error.')

Review Comment:
   Being a SQLAlchemy novice here, but it looks like using a context manager here for the session object should suffice? And the `session.commit()` doesn't seem necessary since there is only read activity with the session. Unless I'm missing something looking at the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org