You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/10 22:01:36 UTC
[GitHub] [incubator-mxnet] sl1pkn07 opened a new issue #17806: [Q][BUG]
Little thing with DMLC-Core stuff and other submodules
sl1pkn07 opened a new issue #17806: [Q][BUG] Little thing with DMLC-Core stuff and other submodules
URL: https://github.com/apache/incubator-mxnet/issues/17806
Hi
i found wreid things with DMLC-Core stuff (and others) in the project when build it.
https://github.com/apache/incubator-mxnet/blob/afb8742e6e1e987833b39c487dc892b5537196a1/CMakeLists.txt#L507-L509
the L507 and L509 is not need because seems dmlc-core is a hard dependency , also lead to fail build because the dmlc sources is not found if not download it (if the user avoid run `git submodules update --init` or run `git submoule update <dependencycomponent>` manually)
also
https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L889
is really necessary install the dmlc-core headers when install mxnet? [see notes below]
also when install mxnet (`make install`), the dmlc-core stuff is also installed (twice, one by dmlc-core iself when do `make install` and other hardcoded in the main CMakeLists.txt):
~~~
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dlpack
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dlpack/dlpack.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/type_traits.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/timer.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/threadediter.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/thread_local.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/thread_group.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/strtonum.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/serializer.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/registry.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/recordio.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/parameter.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/optional.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/omp.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/memory_io.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/memory.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/lua.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/logging.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/json.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/io.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/input_split_shuffle.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/filesystem.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/endian.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/data.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/config.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/concurrentqueue.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/concurrency.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/common.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/build_config_default.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/blockingconcurrentqueue.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/base.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/array_view.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/any.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/mshadow
~~~
and later
~~~
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/nnvm/base.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/type_traits.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/timer.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/threadediter.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/thread_local.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/thread_group.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/strtonum.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/serializer.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/registry.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/recordio.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/parameter.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/optional.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/omp.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/memory_io.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/memory.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/lua.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/logging.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/json.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/io.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/input_split_shuffle.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/filesystem.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/endian.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/data.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/config.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/concurrentqueue.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/concurrency.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/common.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/build_config_default.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/blockingconcurrentqueue.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/base.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/array_view.h
-- Up-to-date: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/any.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/include/dmlc/build_config.h
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/lib/libdmlc.a
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/lib/cmake/dmlc/DMLCTargets.cmake
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/lib/cmake/dmlc/DMLCTargets-none.cmake
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/lib/cmake/dmlc/dmlc-config.cmake
-- Installing: /tmp/makepkg/sl1-mxnet-git/pkg/sl1-mxnet-git/usr/lib/cmake/dmlc/dmlc-config-version.cmake
~~~
seems need add in https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L508 `EXCLUDE_FROM_ALL` for avoid invoke `make install` in the subproject
if not, also have a side effect if have you already installed by system package the dmlc-core project
also occur with
https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L888-L895
is really necessary install it ( dlpack, mkldnn, msshadow, tvm) with mxnet? same as avobe , this lead to fail if have already installed in the system
any thought? is a bug?
greetings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services