You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/14 17:26:59 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #13699: [Client] Fix send chunking message failed when ordering key is set.

BewareMyPower commented on pull request #13699:
URL: https://github.com/apache/pulsar/pull/13699#issuecomment-1013315994


   From my perspective, it's so terrible to have all these issues just because all chunks share the same `MessageMetadata`. I'd like just deep copying this object instead of sharing the object and setting some fields carefully.
   
   I also realized this potential issue when I implement the chunking message feature for C++ client, so I do the deep copy for the initial implementation.
   
   Though for the sake of overhead of bytes copy, this solution looks good. But does it really affect? So I won't approve but neither will I request changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org