You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/11/15 18:52:45 UTC

[GitHub] beam pull request #4137: Specifies numShards on windowed writes examples, as...

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/4137

    Specifies numShards on windowed writes examples, as it is now required

    When doing windowed writes, one now must specify the number of shards, because it's not possible to assign shard numbers automatically and deterministically. Before https://github.com/apache/beam/pull/4124 it was allowed to not specify number of shards for bounded PCollection's when doing windowed writes, but a streaming runner writing a bounded PCollection could technically produce non-deterministic results.
    
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam fix-windowed-write-examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4137
    
----
commit 7ee94938e5d6d81656cdc8f56e2af9400572266e
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-11-15T18:48:52Z

    Specifies numShards on windowed writes examples, as it is now required

----


---

[GitHub] beam pull request #4137: [BEAM-3195] Specifies numShards on windowed writes ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/4137


---