You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/07/10 21:58:56 UTC
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/98
CB-9335: Windows quality-of-life improvements.
This change documents the separator between and how to specify multiple architectures using the
--archs argument to build and run.
Removed the Windows 8 project from the Visual Studio 2013 solution. It is still possible to use Visual Studio 2013 to work on the Windows 8 project; to do so, load the CordovaApp.vs2012.sln into Visual Studio 2013.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit b155279650ea6e7d78dc89f04ff16d0ae63af36a
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-07-08T22:08:17Z
CB-9335: Windows quality-of-life improvements. This change documents the
separator between and how to specify multiple architectures using the
--archs argument to build and run.
Removed the Windows 8 project from the Visual Studio 2013 solution. It
is still possible to use Visual Studio 2013 to work on the Windows 8
project; to do so, load the CordovaApp.vs2012.sln into Visual Studio 2013.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120985543
@TimBarham We don't require any changes to jsprojManager because this change didn't change any .jsprojes, only .slns.
I'll go ahead and make the corresponding change to cordova-lib, but yes, this should be ready to merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-121090097
Note that `jsprojManager` does manipulate the sln files (see `addProjectReference()` and `removeProjectReference()`, which correspond to a `framework` element with `type="projectReference"`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
Looks good to me.
Have you verified no changes need to be made to `cordova-lib/src/util/windows/jsprojManager.js` (adding/removing plugins that use `<lib-file>` or `<framework>` elements for the windows platform)? Also, you might want to update `cordova-lib/spec-plugman/projects/windows/CordovaApp.sln` to reflect this change.
Assuming that's all good, is this ready to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120508148
Looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org