You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/31 08:26:41 UTC

[GitHub] [hbase] wchevreuil commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe

wchevreuil commented on a change in pull request #2180:
URL: https://github.com/apache/hbase/pull/2180#discussion_r463474952



##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -69,7 +69,7 @@
     Compression.Algorithm.NONE, Compression.Algorithm.GZ
   };
 
-  protected Configuration conf;
+  protected final Configuration conf;

Review comment:
       > I think we should just release note the break, especially given the on-going issue of "should we be labeling these things IA.Public yet?"
   
   Agreed with putting description on the release notes. And feel weird that these are IA Public, should it be changed to IA Private here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org