You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/10 16:46:03 UTC

[GitHub] [ozone] umamaheswararao commented on a change in pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes

umamaheswararao commented on a change in pull request #3062:
URL: https://github.com/apache/ozone/pull/3062#discussion_r803879546



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -256,12 +256,9 @@ private ContainerWithPipeline getContainerWithPipelineCommon(
     }
 
     if (pipeline == null) {

Review comment:
       I think it's not safe design to pass the COntainerReplicas directly to pluggable pipeline creator classes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org