[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4089: Fix some problem related with publish version task

[GitBox <gi...@apache.org>]

yangzhg commented on a change in pull request #4089:
URL: https://github.com/apache/incubator-doris/pull/4089#discussion_r454755688



##########
File path: fe/src/main/java/org/apache/doris/catalog/Replica.java
##########
@@ -318,12 +318,17 @@ private void updateReplicaInfo(long newVersion, long newVersionHash,
             long lastFailedVersion, long lastFailedVersionHash, 
             long lastSuccessVersion, long lastSuccessVersionHash, 
             long newDataSize, long newRowCount) {
-        LOG.debug("before update: {}", this.toString());
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("before update: {}", this.toString());
+        }
 
         if (newVersion < this.version) {
-            // yiguolei: could not find any reason why new version less than this.version should run???
-            LOG.warn("replica {} on backend {}'s new version {} is lower than meta version {}",
-                    id, backendId, newVersion, this.version);
+            // This case means that replica meta version has been updated by ReportHandler before

Review comment:
       why the replica meta version been updated by ReportHandler before?
   this is abnormal, I think using waring is better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org