You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jean-frederic Clere <jf...@gmail.com> on 2006/01/19 14:46:25 UTC
modules/aaa/mod_authz_owner.c
Hi,
On ReliantUnix the following code can't be compiled:
+++
typedef struct {
} authz_owner_config_rec;
+++
Because the structure is empty.
Any problem to apply the following patch:
+++
Index: aaa/mod_authz_owner.c
===================================================================
--- aaa/mod_authz_owner.c (revision 370359)
+++ aaa/mod_authz_owner.c (working copy)
@@ -29,14 +29,13 @@
#include "mod_auth.h" /* for AUTHZ_GROUP_NOTE */
-typedef struct {
-} authz_owner_config_rec;
+typedef struct authz_owner_config_rec_struct *authz_owner_config_rec_ptr;
APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec
*r));
static void *create_authz_owner_dir_config(apr_pool_t *p, char *d)
{
- authz_owner_config_rec *conf = apr_palloc(p, sizeof(*conf));
+ authz_owner_config_rec_ptr conf = apr_palloc(p, sizeof(conf));
return conf;
}
+++
Cheers
Jean-Frederic
Re: modules/aaa/mod_authz_owner.c
Posted by Brad Nicholes <BN...@novell.com>.
>>> On 1/19/2006 at 6:46:25 am, in message
<43...@gmail.com>,
jfclere@gmail.com wrote:
> Hi,
>
> On ReliantUnix the following code can't be compiled:
> +++
> typedef struct {
> } authz_owner_config_rec;
> +++
> Because the structure is empty.
>
> Any problem to apply the following patch:
> +++
> Index: aaa/mod_authz_owner.c
> ===================================================================
> --- aaa/mod_authz_owner.c (revision 370359)
> +++ aaa/mod_authz_owner.c (working copy)
> @@ -29,14 +29,13 @@
>
> #include "mod_auth.h" /* for AUTHZ_GROUP_NOTE */
>
> -typedef struct {
> -} authz_owner_config_rec;
> +typedef struct authz_owner_config_rec_struct
*authz_owner_config_rec_ptr;
>
> APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group,
(request_rec
> *r));
>
> static void *create_authz_owner_dir_config(apr_pool_t *p, char *d)
> {
> - authz_owner_config_rec *conf = apr_palloc(p, sizeof(*conf));
> + authz_owner_config_rec_ptr conf = apr_palloc(p, sizeof(conf));
>
> return conf;
> }
> +++
>
> Cheers
>
> Jean-Frederi
It should probably just be removed since it is no longer needed. After
the refactoring there was no need to store any per-dir-config
information so the structure was just left empty. I will be committing
a patch soon.
Brad