You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/05 08:46:26 UTC
[GitHub] [incubator-nuttx-apps] ttnie opened a new pull request #553: ltp: fix build failure with argument too long issue
ttnie opened a new pull request #553:
URL: https://github.com/apache/incubator-nuttx-apps/pull/553
## Summary
fix build failure with argument too long issue
## Impact
no
## Testing
test on local
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #553: ltp: fix build failure with argument too long issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #553:
URL: https://github.com/apache/incubator-nuttx-apps/pull/553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #553: ltp: fix build failure with argument too long issue
Posted by GitBox <gi...@apache.org>.
ttnie commented on a change in pull request #553:
URL: https://github.com/apache/incubator-nuttx-apps/pull/553#discussion_r551799581
##########
File path: testing/ltp/Makefile
##########
@@ -109,6 +109,8 @@ $(LTP_UNPACK):
$(Q) echo "git clone $(LTP_URL)"
$(Q) git clone $(LTP_URL)
+$(LTP_CSRCS): $(LTP_UNPACK)
Review comment:
remove this line, pls review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #553: ltp: fix build failure with argument too long issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #553:
URL: https://github.com/apache/incubator-nuttx-apps/pull/553#discussion_r551795842
##########
File path: testing/ltp/Makefile
##########
@@ -109,6 +109,8 @@ $(LTP_UNPACK):
$(Q) echo "git clone $(LTP_URL)"
$(Q) git clone $(LTP_URL)
+$(LTP_CSRCS): $(LTP_UNPACK)
Review comment:
why need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org