You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/08/15 03:51:09 UTC
[GitHub] ssunorz commented on a change in pull request #2373: Make
authentication parameters configurable on the pulsar-client-kafka
ssunorz commented on a change in pull request #2373: Make authentication parameters configurable on the pulsar-client-kafka
URL: https://github.com/apache/incubator-pulsar/pull/2373#discussion_r210165006
##########
File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/pulsar/client/kafka/compat/PulsarClientKafkaConfig.java
##########
@@ -29,6 +30,8 @@
/// Config variables
public static final String AUTHENTICATION_CLASS = "pulsar.authentication.class";
+ public static final String AUTHENTICATION_PARAMS_MAP = "pulsar.authentication.params.map";
+ public static final String AUTHENTICATION_PARAMS_STRING = "pulsar.authentication.params.string";
Review comment:
@merlimat Thanks for the review. I updated the document according to your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services