You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/26 00:04:12 UTC

[GitHub] [pulsar] klwilson227 opened a new pull request #8709: 8704-improve env config handling

klwilson227 opened a new pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709


   There are three issues addressed in this PR.
   
   1) script files that contain lines other than comments and value
   assignments cause the script to abort not re-writing the file at all.
   These lines should be tolerated if they cannot be parsed as value
   assignments and flow through to the edited results.
   
   2) Redaction of passwords in environment variables. Environment
   variables with a name containing password will automatically be
   redacted and not printed in the log messages.
   
   3) values that contain spaces as in many java args that contain
   stringed together options like "-Xmx ... -Xmn ..." are read from the
   environment without the quotes. These quotes need to be added back
   when writing back to the shell script to ensure that these values are
   processed as a group.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #8709: 8704-improve env config handling

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709#issuecomment-738405681


   @sijie and @codelipenghui - why was 2.7.0 released without this fix? Are there other, recommended ways to configure pulsar components? Additionally, is there a plan to release 2.7.1 soon?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8709: 8704-improve env config handling

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709#issuecomment-734079511


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8709: 8704-improve env config handling

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709#issuecomment-752023315


   @michaeljmarshall Yes, 2.7.0 does not contain this fix because this PR is merged after the 2.7.0 is cut. We are planning to release the 2.7.1 in Mid-January


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #8709: 8704-improve env config handling

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8709: 8704-improve env config handling

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8709:
URL: https://github.com/apache/pulsar/pull/8709#issuecomment-735522829


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org