[GitHub] [superset] nytai commented on a change in pull request #12906: fix: Config for dataset health check

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569074453



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       +1 for that warning, we've seen issues with config values being added after overrides are loaded. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org