[GitHub] [openjpa] struberg commented on a change in pull request #79: HerdDB profile for integration tests

[GitBox <gi...@apache.org>]

struberg commented on a change in pull request #79:
URL: https://github.com/apache/openjpa/pull/79#discussion_r611063825



##########
File path: pom.xml
##########
@@ -1102,6 +1102,58 @@
             </properties>
         </profile>
 
+        <!-- Profile for testing with HerdDB -->
+        <profile>
+            <id>test-herddb-docker</id>
+            <activation>
+                <property>
+                    <name>test-herddb-docker</name>
+                </property>
+            </activation>
+            <dependencies>
+                <dependency>
+                    <groupId>org.herddb</groupId>
+                    <artifactId>herddb-jdbc</artifactId>
+                    <version>0.22.0</version>
+                    <scope>test</scope>
+                </dependency>
+            </dependencies>
+            <properties>
+                <connection.driver.name>herddb.jdbc.Driver</connection.driver.name>

Review comment:
       For me docker is also fine. The benefit of a docker image is that you drop it and have a very well defined initial status.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org