[GitHub] [cordova-ios] dpogue commented on a diff in pull request #1374: (ios) fixes WASM MIME type error by specifying it in Info.plist template

["dpogue (via GitHub)" <gi...@apache.org>]

dpogue commented on code in PR #1374:
URL: https://github.com/apache/cordova-ios/pull/1374#discussion_r1340663989


##########
templates/project/__PROJECT_NAME__/__PROJECT_NAME__-Info.plist:
##########
@@ -45,5 +45,25 @@
 		<string>UIInterfaceOrientationPortraitUpsideDown</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
 	</array>
+	<key>UTExportedTypeDeclarations</key>

Review Comment:
   I'm curious if this also works if you use `UTImportedTypeDeclarations` as the key
   
   I don't think we want to declare all Cordova apps as owners of the WebAssembly file type by default, so `UTExportedTypeDeclarations` seems like it might be the wrong key to use. Even with that though, I think injecting this when needed using `config-file` in config.xml for your app is probably a better choice that unconditionally including this declaration in the template for all Cordova apps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org