You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by cz...@apache.org on 2004/07/12 15:36:43 UTC

cvs commit: cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/transformation ProxyTransformer.java

cziegeler    2004/07/12 06:36:43

  Modified:    src/blocks/portal/java/org/apache/cocoon/portal/reading
                        ProxyReader.java
               src/blocks/portal/java/org/apache/cocoon/portal/transformation
                        ProxyTransformer.java
  Log:
  use NetUtils
  
  Revision  Changes    Path
  1.7       +4 -4      cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/reading/ProxyReader.java
  
  Index: ProxyReader.java
  ===================================================================
  RCS file: /home/cvs/cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/reading/ProxyReader.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ProxyReader.java	19 Mar 2004 14:21:06 -0000	1.6
  +++ ProxyReader.java	12 Jul 2004 13:36:43 -0000	1.7
  @@ -19,7 +19,6 @@
   import java.io.InputStream;
   import java.net.HttpURLConnection;
   import java.net.URL;
  -import java.net.URLEncoder;
   import java.util.Enumeration;
   import java.util.Map;
   
  @@ -32,6 +31,7 @@
   import org.apache.cocoon.portal.coplet.CopletInstanceData;
   import org.apache.cocoon.portal.transformation.ProxyTransformer;
   import org.apache.cocoon.reading.ServiceableReader;
  +import org.apache.cocoon.util.NetUtils;
   import org.xml.sax.SAXException;
   
   /**
  @@ -177,9 +177,9 @@
                           query.append('&');
                       }
   
  -                    query.append(URLEncoder.encode(paramName));
  +                    query.append(NetUtils.encode(paramName, null));
                       query.append('=');
  -                    query.append(URLEncoder.encode(paramValues[i]));
  +                    query.append(NetUtils.encode(paramValues[i], null));
   
                   }
               }
  
  
  
  1.11      +4 -4      cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/transformation/ProxyTransformer.java
  
  Index: ProxyTransformer.java
  ===================================================================
  RCS file: /home/cvs/cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/transformation/ProxyTransformer.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- ProxyTransformer.java	20 Mar 2004 17:02:46 -0000	1.10
  +++ ProxyTransformer.java	12 Jul 2004 13:36:43 -0000	1.11
  @@ -23,7 +23,6 @@
   import java.net.HttpURLConnection;
   import java.net.MalformedURLException;
   import java.net.URL;
  -import java.net.URLEncoder;
   import java.util.Enumeration;
   import java.util.Map;
   
  @@ -43,6 +42,7 @@
   import org.apache.cocoon.portal.coplet.CopletInstanceData;
   import org.apache.cocoon.portal.profile.ProfileManager;
   import org.apache.cocoon.transformation.AbstractTransformer;
  +import org.apache.cocoon.util.NetUtils;
   import org.apache.cocoon.xml.XMLUtils;
   import org.apache.cocoon.xml.dom.DOMStreamer;
   import org.w3c.dom.Document;
  @@ -263,9 +263,9 @@
                               query.append('&');
                           }
   
  -                        query.append(URLEncoder.encode(paramName));
  +                        query.append(NetUtils.encode(paramName, null));
                           query.append('=');
  -                        query.append(URLEncoder.encode(paramValues[i]));
  +                        query.append(NetUtils.encode(paramValues[i], null));
                       }
                   }
               }
  
  
  

RE: cvs commit: cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/transformat ion ProxyTransformer.java

Posted by Carsten Ziegeler <cz...@s-und-n.de>.
+1

Carsten 

> -----Original Message-----
> From: Antonio Gallardo [mailto:agallardo@agssa.net] 
> Sent: Monday, July 12, 2004 3:40 PM
> To: cvs@cocoon.apache.org
> Subject: Re: cvs commit: 
> cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/tra
> nsformat ion ProxyTransformer.java
> 
> cziegeler@apache.org dijo:
> > cziegeler    2004/07/12 06:36:43
> >
> >   Modified:    
> src/blocks/portal/java/org/apache/cocoon/portal/reading
> >                         ProxyReader.java
> >                
> src/blocks/portal/java/org/apache/cocoon/portal/transformation
> >                         ProxyTransformer.java
> >   Log:
> >   use NetUtils
> ....
> >   -                    query.append(URLEncoder.encode(paramName));
> >   +                    
> query.append(NetUtils.encode(paramName, null));
> 
> 
> Perhaps instead of sending a null we can define UTF-8
> 
> NetUtils will gracefully manage it for java 1.3
> 
> WDYT?
> 
> Best Regards,
> 
> Antonio Gallardo.
> 
> 


Re: cvs commit: cocoon-2.1/src/blocks/portal/java/org/apache/cocoon/portal/transformat ion ProxyTransformer.java

Posted by Antonio Gallardo <ag...@agssa.net>.
cziegeler@apache.org dijo:
> cziegeler    2004/07/12 06:36:43
>
>   Modified:    src/blocks/portal/java/org/apache/cocoon/portal/reading
>                         ProxyReader.java
>                src/blocks/portal/java/org/apache/cocoon/portal/transformation
>                         ProxyTransformer.java
>   Log:
>   use NetUtils
....
>   -                    query.append(URLEncoder.encode(paramName));
>   +                    query.append(NetUtils.encode(paramName, null));


Perhaps instead of sending a null we can define UTF-8

NetUtils will gracefully manage it for java 1.3

WDYT?

Best Regards,

Antonio Gallardo.