You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "akashorabek (via GitHub)" <gi...@apache.org> on 2025/02/17 18:38:19 UTC
[PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
akashorabek opened a new pull request, #34008:
URL: https://github.com/apache/beam/pull/34008
Fixes: [#33065](https://github.com/apache/beam/issues/33065)
Temporarily moved to GH hosted ubuntu-22.04
Successful run example: https://github.com/akashorabek/beam/actions/runs/13375479284
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34008:
URL: https://github.com/apache/beam/pull/34008#discussion_r1958856181
##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -61,7 +61,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
startsWith(github.event.comment.body, 'Run Python ValidatesContainer Dataflow ARM')
- runs-on: [self-hosted, ubuntu-20.04, main]
Review Comment:
I think we should fix the self host image. I also remember the github secret does not work for now. cc: @damccorm Is Beam repo's secret fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on code in PR #34008:
URL: https://github.com/apache/beam/pull/34008#discussion_r1959202387
##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -61,7 +61,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
startsWith(github.event.comment.body, 'Run Python ValidatesContainer Dataflow ARM')
- runs-on: [self-hosted, ubuntu-20.04, main]
Review Comment:
This test was failing due to a known issue where the building_wheels step fails on self-hosted runners. This is a temporary solution; once we make progress on [this issue](https://github.com/apache/beam/issues/33506), we can revert the workflow back to self-hosted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34008:
URL: https://github.com/apache/beam/pull/34008#discussion_r1959911904
##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -61,7 +61,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
startsWith(github.event.comment.body, 'Run Python ValidatesContainer Dataflow ARM')
- runs-on: [self-hosted, ubuntu-20.04, main]
Review Comment:
> Is Beam repo's secret fixed?
Yeah, I fixed this.
In general, I'm fine moving to hosted runners for now until we figure out what is wrong with self-hosted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on PR #34008:
URL: https://github.com/apache/beam/pull/34008#issuecomment-2663871689
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34008:
URL: https://github.com/apache/beam/pull/34008#discussion_r1959913440
##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -61,7 +61,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
startsWith(github.event.comment.body, 'Run Python ValidatesContainer Dataflow ARM')
- runs-on: [self-hosted, ubuntu-20.04, main]
Review Comment:
@Abacn let me know if you have other concerns, or feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34008:
URL: https://github.com/apache/beam/pull/34008#issuecomment-2663873419
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python ValidatesContainer Dataflow ARM workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #34008:
URL: https://github.com/apache/beam/pull/34008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org