You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/27 21:18:32 UTC
[GitHub] [spark] viirya opened a new pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
viirya opened a new pull request #30939:
URL: https://github.com/apache/spark/pull/30939
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch proposes to upgrade Kafka version to 2.7.0 for Spark 3.2.0.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To catch up with latest Kafka bug fix and features: https://downloads.apache.org/kafka/2.7.0/RELEASE_NOTES.html
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751727209
**[Test build #133425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133425/testReport)** for PR 30939 at commit [`91a6ccd`](https://github.com/apache/spark/commit/91a6ccd0ac017b7ab8122103aa183969f6e0c91d).
* This patch **fails from timeout after a configured wait of `500m`**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751588656
**[Test build #133425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133425/testReport)** for PR 30939 at commit [`91a6ccd`](https://github.com/apache/spark/commit/91a6ccd0ac017b7ab8122103aa183969f6e0c91d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ijuma commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-783898758
FYI, we adjusted the optimizer configs for Kafka to avoid the exact Scala patch version dependency issue: https://github.com/apache/kafka/pull/10174
It will be part of Kafka 2.8.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751738284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133425/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751588977
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38016/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751586973
In short, the Scala compiler had a critical bug.
- [scala/bug#12096](https://github.com/scala/bug/issues/12096)
- [scala/bug#12002](https://github.com/scala/bug/issues/12002)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751585923
No, @viirya . We detected the issues six month ago and made a Spark-side adaptation via SPARK-32436 on July 2020.
Please see the discussion here for the technical details and Scala side bug IDs. AFAIK, the bug is in Scala 2.12.12 and we are waiting for 2.12.13 .
- https://github.com/apache/spark/pull/29231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751525408
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38003/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751539921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133413/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751525719
**[Test build #133413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133413/testReport)** for PR 30939 at commit [`2443950`](https://github.com/apache/spark/commit/24439506bf0fcacd4057c09c56108f90431a715a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751521281
**[Test build #133412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133412/testReport)** for PR 30939 at commit [`670ec1d`](https://github.com/apache/spark/commit/670ec1da9a67494fe2c933d22a288bb784b85ad2).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751532170
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38004/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751525408
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38003/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #30939:
URL: https://github.com/apache/spark/pull/30939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751738284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133425/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751584337
> Hi, @viirya . Sorry, but, are you sure about Scala 2.12.12?
>
> I commented on your original Scala 2.12.12 PR, too.
>
> * [#30940 (comment)](https://github.com/apache/spark/pull/30940#issuecomment-751581096)
Yea, I just saw it. If we don't want Scala 2.12.12, seems we cannot upgrade Kafka 2.7.0 too: https://github.com/apache/spark/pull/30940#issuecomment-751583360.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751585923
No, @viirya . You may not notice the bug, because we detected the issues six month ago and made a Spark-side adaptation via SPARK-32436 on July 2020.
Please see the discussion here for the technical details and Scala side bug IDs. AFAIK, the bug is in Scala 2.12.12 and we are waiting for 2.12.13 .
- https://github.com/apache/spark/pull/29231 ([SPARK-32436][CORE] Initialize numNonEmptyBlocks in HighlyCompressedMapStatus.readExternal)
- https://github.com/apache/spark/pull/29124 ([WIP][SPARK-31168][BUILD] Upgrade Scala to 2.12.12)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751521288
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133412/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751584528
I'm going to see Jenkins test to verify it, although I already experimented locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751588977
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38016/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751546537
Created #30940 for upgrading Scala 2.12 patch version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-786001288
Thank you, @ijuma .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751520772
**[Test build #133412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133412/testReport)** for PR 30939 at commit [`670ec1d`](https://github.com/apache/spark/commit/670ec1da9a67494fe2c933d22a288bb784b85ad2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751525719
**[Test build #133413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133413/testReport)** for PR 30939 at commit [`2443950`](https://github.com/apache/spark/commit/24439506bf0fcacd4057c09c56108f90431a715a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751532170
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38004/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751587718
Got it, @viirya . For testing purpose, there is no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751586964
> No, @viirya . You may not notice the bug, because we detected the issues six month ago and made a Spark-side adaptation via [SPARK-32436](https://issues.apache.org/jira/browse/SPARK-32436) on July 2020.
>
> Please see the discussion here for the technical details and Scala side bug IDs. AFAIK, the bug is in Scala 2.12.12 and we are waiting for 2.12.13 .
>
> * #29231
I'm reading https://github.com/scala/bug/issues/12096. I understood Scala 2.12.12 was skipped now. I just meant if we cannot upgrade to Scala 2.12.12, then upgrading Kafka 2.7.0 is blocked by it.
Then we may also wait for next Kafka version which uses Scala 2.12.13 (if there is).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751706504
Right, I think we'd just have to skip this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751585923
No, @viirya . You may not notice the bug, because we detected the issues six month ago and made a Spark-side adaptation via SPARK-32436 on July 2020.
Please see the discussion here for the technical details and Scala side bug IDs. AFAIK, the bug is in Scala 2.12.12 and we are waiting for 2.12.13 .
- https://github.com/apache/spark/pull/29231
- https://github.com/apache/spark/pull/29124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751539714
**[Test build #133413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133413/testReport)** for PR 30939 at commit [`2443950`](https://github.com/apache/spark/commit/24439506bf0fcacd4057c09c56108f90431a715a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751520772
**[Test build #133412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133412/testReport)** for PR 30939 at commit [`670ec1d`](https://github.com/apache/spark/commit/670ec1da9a67494fe2c933d22a288bb784b85ad2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751521288
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133412/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751801115
Thanks for discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751586333
cc @srowen and @mridulm who were together on the original PR for Scala 2.12.12 bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751588656
**[Test build #133425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133425/testReport)** for PR 30939 at commit [`91a6ccd`](https://github.com/apache/spark/commit/91a6ccd0ac017b7ab8122103aa183969f6e0c91d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751544146
Yea, it's the same issue as https://github.com/embeddedkafka/embedded-kafka/issues/202. We need to bump Scala patch version to match Kafka's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751539921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133413/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30939: [SPARK-33913][BUILD] Upgrade kafka to 2.7.0
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30939:
URL: https://github.com/apache/spark/pull/30939#discussion_r549171834
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -574,11 +574,11 @@ class KafkaTestUtils(
s"topic $topic still exists in the replica manager")
// ensure that logs from all replicas are deleted if delete topic is marked successful
assert(servers.forall(server => topicAndPartitions.forall(tp =>
- server.getLogManager().getLog(tp).isEmpty)),
+ server.getLogManager.getLog(tp).isEmpty)),
Review comment:
https://github.com/apache/kafka/pull/8931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30939: [DO-NOT-MERGE][SPARK-33913][SPARK-33921][BUILD] Upgrade kafka to 2.7.0 and Upgrade Scala version to 2.12.12
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30939:
URL: https://github.com/apache/spark/pull/30939#issuecomment-751585923
No, @viirya . You may not notice the bug, because we detected the issues six month ago and made a Spark-side adaptation via SPARK-32436 on July 2020.
Please see the discussion here for the technical details and Scala side bug IDs. AFAIK, the bug is in Scala 2.12.12 and we are waiting for 2.12.13 .
- https://github.com/apache/spark/pull/29231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org