You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by go...@apache.org on 2019/10/23 16:15:07 UTC
[storm] branch 2.1.x-branch updated: STORM-3515: Readds ability to
list all blobstore lists via Storm CLI
This is an automated email from the ASF dual-hosted git repository.
govind pushed a commit to branch 2.1.x-branch
in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/2.1.x-branch by this push:
new 2da0510 STORM-3515: Readds ability to list all blobstore lists via Storm CLI
2da0510 is described below
commit 2da0510967023a4906b8d66e5c7aa3a23ccbc7c2
Author: Govind Menon <go...@gmail.com>
AuthorDate: Thu Oct 10 09:48:56 2019 -0500
STORM-3515: Readds ability to list all blobstore lists via Storm CLI
---
bin/storm.py | 2 +-
storm-client/test/py/test_storm_cli.py | 14 ++++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/bin/storm.py b/bin/storm.py
index 9c45c26..48b9cf3 100755
--- a/bin/storm.py
+++ b/bin/storm.py
@@ -588,7 +588,7 @@ def initialize_blobstore_subcommand(subparsers):
"list", help="lists blobs currently in the blob store", formatter_class=SortingHelpFormatter
)
list_parser.add_argument(
- "keys", nargs='+')
+ "keys", nargs='*')
add_common_options(list_parser, main_args=False)
cat_parser = sub_sub_parsers.add_parser(
diff --git a/storm-client/test/py/test_storm_cli.py b/storm-client/test/py/test_storm_cli.py
index 8084452..d187fe5 100644
--- a/storm-client/test/py/test_storm_cli.py
+++ b/storm-client/test/py/test_storm_cli.py
@@ -177,6 +177,20 @@ class TestStormCli(TestCase):
self.mock_execvp.reset_mock()
self.base_test([
+ 'storm', 'blobstore', 'list'
+ ], self.mock_execvp, mock.call(
+ self.java_cmd, [
+ self.java_cmd, '-client', '-Ddaemon.name=', '-Dstorm.options=',
+ '-Dstorm.home=' + self.storm_dir + '',
+ '-Dstorm.log.dir=' + self.storm_dir + "/logs", '-Djava.library.path=',
+ '-Dstorm.conf.file=', '-cp',
+ '' + self.storm_dir + '/*:' + self.storm_dir + '/lib:' + self.storm_dir +
+ '/extlib:' + self.storm_dir + '/extlib-daemon:' + self.storm_dir + '/conf:' +
+ self.storm_dir + '/bin', 'org.apache.storm.command.Blobstore', 'list'])
+ )
+ self.mock_execvp.reset_mock()
+
+ self.base_test([
'storm', 'blobstore', 'list', 'wordstotrack'
], self.mock_execvp, mock.call(
self.java_cmd, [