You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/22 10:53:13 UTC
[jira] Created: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
[classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
---------------------------------------------------------------------------------------------------------------
Key: HARMONY-1255
URL: http://issues.apache.org/jira/browse/HARMONY-1255
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Andrew Zhang
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
Futhurmore, RI 6.0 still insists on throwing NPE.
I'll upload a patch to fix this problem.
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1255?page=all ]
Paulex Yang reassigned HARMONY-1255:
------------------------------------
Assignee: Paulex Yang
> [classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1255
> URL: http://issues.apache.org/jira/browse/HARMONY-1255
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1255.diff
>
>
> java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
> According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
> Futhurmore, RI 6.0 still insists on throwing NPE.
> I'll upload a patch to fix this problem.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1255?page=all ]
Paulex Yang closed HARMONY-1255.
--------------------------------
Verified by Andrew.
> [classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1255
> URL: http://issues.apache.org/jira/browse/HARMONY-1255
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1255.diff
>
>
> java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
> According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
> Futhurmore, RI 6.0 still insists on throwing NPE.
> I'll upload a patch to fix this problem.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1255?page=comments#action_12429946 ]
Andrew Zhang commented on HARMONY-1255:
---------------------------------------
Thanks Paulex,
The fix looks fine.
Best regards,
Andrew
> [classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1255
> URL: http://issues.apache.org/jira/browse/HARMONY-1255
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1255.diff
>
>
> java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
> According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
> Futhurmore, RI 6.0 still insists on throwing NPE.
> I'll upload a patch to fix this problem.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1255?page=all ]
Andrew Zhang updated HARMONY-1255:
----------------------------------
Attachment: Harmony-1255.diff
Hi,
Would you please try my patch? The patch will make Harmony Handler/MemoryHandler/StreamHandler.isLoggable(null) behaves exactly the same as RI.
Thanks!
Best regards,
Andrew
> [classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1255
> URL: http://issues.apache.org/jira/browse/HARMONY-1255
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: Harmony-1255.diff
>
>
> java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
> According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
> Futhurmore, RI 6.0 still insists on throwing NPE.
> I'll upload a patch to fix this problem.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1255) [classlib][logging]compatibility:
java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI
throws.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1255?page=all ]
Paulex Yang resolved HARMONY-1255.
----------------------------------
Resolution: Fixed
Andrew , patch applied at revision r433900, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][logging]compatibility: java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1255
> URL: http://issues.apache.org/jira/browse/HARMONY-1255
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1255.diff
>
>
> java.util.logging.Handler.isLoggable(null) doesn't throw NPE while RI throws. Although spec says it should return false if the LogRecord is null, RI throws NPE.
> According to exception compatibility guideline, I think we'd better follow RI for this case. After all, RI's behaviour is very logical, except for breaking spec. :)
> Futhurmore, RI 6.0 still insists on throwing NPE.
> I'll upload a patch to fix this problem.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira