You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "7hong (via GitHub)" <gi...@apache.org> on 2024/10/22 08:15:41 UTC
[PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
7hong opened a new pull request, #3290:
URL: https://github.com/apache/amoro/pull/3290
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3289 .
## How was this patch tested?
In my environment, there is a table with many partitions waiting to be merged. Each plan is very time-consuming. After optimization, the time-consuming is significantly reduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
Posted by "baiyangtx (via GitHub)" <gi...@apache.org>.
baiyangtx commented on PR #3290:
URL: https://github.com/apache/amoro/pull/3290#issuecomment-2458624718
Will the old code trigger a reload of TableMetadata?
It seems that if the reloading of TableMetadata is not triggered, the performance of the new code is the same as that of the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
Posted by "7hong (via GitHub)" <gi...@apache.org>.
7hong commented on PR #3290:
URL: https://github.com/apache/amoro/pull/3290#issuecomment-2511333608
@czy006
Flame graph before optimization：
Flame graph after optimization:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3290:
URL: https://github.com/apache/amoro/pull/3290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
Posted by "7hong (via GitHub)" <gi...@apache.org>.
7hong commented on PR #3290:
URL: https://github.com/apache/amoro/pull/3290#issuecomment-2461430749
@baiyangtx
Yes, the old code will refresh the TableMetadata. Especially when calling the `getUGI` method in an environment with Kerberos enabled, it will enter a synchronous blocking state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARORO-3289] Avoid calling getMixedTablePartitionSpecById in the scan loop [amoro]
Posted by "7hong (via GitHub)" <gi...@apache.org>.
7hong commented on PR #3290:
URL: https://github.com/apache/amoro/pull/3290#issuecomment-2434090172
@zhoujinsong @majin1102 Do you have time to review it? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org