You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Colin MacNaughton (JIRA)" <ji...@apache.org> on 2009/03/17 04:12:39 UTC

[jira] Created: (AMQ-2165) activemq-flow: ISourceController and ISinkController interfaces should be updated to take use Generics for increased flexibility

activemq-flow: ISourceController and ISinkController interfaces should be updated to take use <?> Generics for increased flexibility
------------------------------------------------------------------------------------------------------------------------------------

                 Key: AMQ-2165
                 URL: https://issues.apache.org/activemq/browse/AMQ-2165
             Project: ActiveMQ
          Issue Type: Improvement
    Affects Versions: incubation
         Environment: N/A
            Reporter: Colin MacNaughton
            Priority: Minor
             Fix For: incubation


ISinkController and ISourceController's should pass wildcard generic versions of themselves to one another to increase flexibility of passing elements of common base types to one another:

ISinkController<E> should use:

public void add(E elem, ISourceController<?> controller); //instead of:  public void add(E elem, ISourceController<E> controller);
public void offer(E elem, ISourceController<?> controller); //instead of  public void offer(E elem, ISourceController<E> controller);

and ISinkController<E> should use:
public void onFlowBlock(ISinkController<?> controller); //instead of public void onFlowBlock(ISinkController<E> controller)
public void onFlowResume(ISinkController<?> controller); //instead of public void onFlowResume(ISinkController<E> controller); //instead of

This allows for type conversions of elements between flow controllers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2165) activemq-flow: ISourceController and ISinkController interfaces should be updated to take use Generics for increased flexibility

Posted by "Colin MacNaughton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin MacNaughton updated AMQ-2165:
-----------------------------------

    Attachment: AMQ-2165patch.txt

Patch file containing interface changes along with supporting updates to IFlowSink and implementors. 

> activemq-flow: ISourceController and ISinkController interfaces should be updated to take use <?> Generics for increased flexibility
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-2165
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2165
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: incubation
>         Environment: N/A
>            Reporter: Colin MacNaughton
>            Priority: Minor
>             Fix For: incubation
>
>         Attachments: AMQ-2165patch.txt
>
>
> ISinkController and ISourceController's should pass wildcard generic versions of themselves to one another to increase flexibility of passing elements of common base types to one another:
> ISinkController<E> should use:
> public void add(E elem, ISourceController<?> controller); //instead of:  public void add(E elem, ISourceController<E> controller);
> public void offer(E elem, ISourceController<?> controller); //instead of  public void offer(E elem, ISourceController<E> controller);
> and ISinkController<E> should use:
> public void onFlowBlock(ISinkController<?> controller); //instead of public void onFlowBlock(ISinkController<E> controller)
> public void onFlowResume(ISinkController<?> controller); //instead of public void onFlowResume(ISinkController<E> controller); //instead of
> This allows for type conversions of elements between flow controllers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2165) activemq-flow: ISourceController and ISinkController interfaces should be updated to take use Generics for increased flexibility

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-2165.
--------------------------------

    Resolution: Fixed

Applied.  Thx!

> activemq-flow: ISourceController and ISinkController interfaces should be updated to take use <?> Generics for increased flexibility
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-2165
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2165
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: incubation
>         Environment: N/A
>            Reporter: Colin MacNaughton
>            Priority: Minor
>             Fix For: incubation
>
>         Attachments: AMQ-2165patch.txt
>
>
> ISinkController and ISourceController's should pass wildcard generic versions of themselves to one another to increase flexibility of passing elements of common base types to one another:
> ISinkController<E> should use:
> public void add(E elem, ISourceController<?> controller); //instead of:  public void add(E elem, ISourceController<E> controller);
> public void offer(E elem, ISourceController<?> controller); //instead of  public void offer(E elem, ISourceController<E> controller);
> and ISinkController<E> should use:
> public void onFlowBlock(ISinkController<?> controller); //instead of public void onFlowBlock(ISinkController<E> controller)
> public void onFlowResume(ISinkController<?> controller); //instead of public void onFlowResume(ISinkController<E> controller); //instead of
> This allows for type conversions of elements between flow controllers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.