[jira] Closed: (TILES-305) NPE in InsertAttributeTag when using ignore flag

["Antonio Petrelli (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/struts/browse/TILES-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli closed TILES-305.
----------------------------------


Closed due to the release of Tiles 2.1.1

> NPE in InsertAttributeTag when using ignore flag
> ------------------------------------------------
>
>                 Key: TILES-305
>                 URL: https://issues.apache.org/struts/browse/TILES-305
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.1.0
>            Reporter: Oleg Gorobets
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.1
>
>         Attachments: InsertAttributeTag.patch
>
>
> Current implementation of InsertAttributeTag throws NPE if there is no such attribute and ignore flag is set to true. GetAsStringTag implies not-null attribute while InsertAttributeTag from which it is derived misses check of  ignore flag before rendering. Need to add simple check in InsertAttributeTag.render() like it was in tiles-2.0.5:
> if (attr == null && ignore) {
>       return;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.