You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2024/11/19 13:24:45 UTC
[PR] feat(cmd): add more information to shutdown log [kvrocks]
PragmaTwice opened a new pull request, #2672:
URL: https://github.com/apache/kvrocks/pull/2672
"Bye bye" seems useless and doesn't contain any information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cmd): add more information to shutdown log [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #2672:
URL: https://github.com/apache/kvrocks/pull/2672#discussion_r1848467522
##########
src/cli/main.cc:
##########
@@ -116,6 +116,7 @@ static void InitGoogleLog(const Config *config) {
int main(int argc, char *argv[]) {
srand(static_cast<unsigned>(util::GetTimeStamp()));
+ crc64_init();
Review Comment:
Curious why crc64 change to here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cmd): add more information to shutdown log [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #2672:
URL: https://github.com/apache/kvrocks/pull/2672#discussion_r1848368635
##########
src/cli/main.cc:
##########
@@ -47,7 +47,7 @@ Server *srv = nullptr;
extern "C" void SignalHandler([[maybe_unused]] int sig) {
if (srv && !srv->IsStopped()) {
- LOG(INFO) << "Bye Bye";
+ LOG(INFO) << "Signal " << sig << " received, stoping the server";
Review Comment:
```suggestion
LOG(INFO) << "Signal " << sig << " received, stopping the server";
```
##########
src/commands/cmd_server.cc:
##########
@@ -544,7 +544,7 @@ class CommandShutdown : public Commander {
}
if (!srv->IsStopped()) {
- LOG(INFO) << "bye bye";
+ LOG(INFO) << "SHUTDOWN command received, stoping the server";
Review Comment:
```suggestion
LOG(INFO) << "SHUTDOWN command received, stopping the server";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cmd): add more information to shutdown log [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2672:
URL: https://github.com/apache/kvrocks/pull/2672#issuecomment-2486337567
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2672) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2672&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2672&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2672&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [60.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2672&metric=new_coverage&view=list)
 [1.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2672&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2672)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cmd): add more information to shutdown log [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #2672:
URL: https://github.com/apache/kvrocks/pull/2672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cmd): add more information to shutdown log [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #2672:
URL: https://github.com/apache/kvrocks/pull/2672#discussion_r1848489558
##########
src/cli/main.cc:
##########
@@ -116,6 +116,7 @@ static void InitGoogleLog(const Config *config) {
int main(int argc, char *argv[]) {
srand(static_cast<unsigned>(util::GetTimeStamp()));
+ crc64_init();
Review Comment:
I think it should be in the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org