You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by to...@apache.org on 2015/09/29 14:49:41 UTC

svn commit: r1705850 - in /lucene/dev/trunk/lucene/classification/src: java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java

Author: tommaso
Date: Tue Sep 29 12:49:40 2015
New Revision: 1705850

URL: http://svn.apache.org/viewvc?rev=1705850&view=rev
Log:
LUCENE-6435 - applied Adrien Grand's patch to avoid CME on SNBC

Modified:
    lucene/dev/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java
    lucene/dev/trunk/lucene/classification/src/test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java

Modified: lucene/dev/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java?rev=1705850&r1=1705849&r2=1705850&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java (original)
+++ lucene/dev/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java Tue Sep 29 12:49:40 2015
@@ -150,8 +150,10 @@ public class SimpleNaiveBayesClassifier
     int docsWithClassSize = countDocsWithClass();
     while ((next = termsEnum.next()) != null) {
       if (next.length > 0) {
+        // We are passing the term to IndexSearcher so we need to make sure it will not change over time
+        next = BytesRef.deepCopyOf(next);
         double clVal = calculateLogPrior(next, docsWithClassSize) + calculateLogLikelihood(tokenizedDoc, next, docsWithClassSize);
-        dataList.add(new ClassificationResult<>(BytesRef.deepCopyOf(next), clVal));
+        dataList.add(new ClassificationResult<>(next, clVal));
       }
     }
 

Modified: lucene/dev/trunk/lucene/classification/src/test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/classification/src/test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java?rev=1705850&r1=1705849&r2=1705850&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/classification/src/test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java (original)
+++ lucene/dev/trunk/lucene/classification/src/test/org/apache/lucene/classification/SimpleNaiveBayesClassifierTest.java Tue Sep 29 12:49:40 2015
@@ -88,7 +88,6 @@ public class SimpleNaiveBayesClassifierT
     }
   }
 
-  @Ignore
   @Test
   public void testPerformance() throws Exception {
     MockAnalyzer analyzer = new MockAnalyzer(random());