You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by dieb <gi...@git.apache.org> on 2017/11/22 18:47:57 UTC
[GitHub] commons-lang pull request #309: Fix EventCountCircuitBreaker increment batch
GitHub user dieb opened a pull request:
https://github.com/apache/commons-lang/pull/309
Fix EventCountCircuitBreaker increment batch
Fixes #incrementAndCheckState(Integer increment) by passing the increment downstream.
I wasn't very sure which additional tests should be added, open to suggestions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dieb/commons-lang dieb/fix-count-cb-bigger-increment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit f9a4bef179887b032c9338af42ea697f457d4e14
Author: Andre Dieb <di...@spotify.com>
Date: 2017-11-22T18:44:23Z
Fix EventCountCircuitBreaker increment batch
Fixes #incrementAndCheckState(Integer increment) by passing the increment downstream.
----
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/309
[](https://coveralls.io/builds/14329343)
Coverage remained the same at 95.168% when pulling **f9a4bef179887b032c9338af42ea697f457d4e14 on dieb:dieb/fix-count-cb-bigger-increment** into **6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/309
Thank you for taking your time to submit the pull request, and for closing it now :-)
---
[GitHub] commons-lang pull request #309: Fix EventCountCircuitBreaker increment batch
Posted by dieb <gi...@git.apache.org>.
Github user dieb closed the pull request at:
https://github.com/apache/commons-lang/pull/309
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/309
Merge request merged in 7d061e33e59e23dc4b03378f35f50a7d70f033b3. Alas, I forgot to amend the commit to include the alias to close this pull request automatically.
@dieb could you close it, please?
Thanks!
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by dieb <gi...@git.apache.org>.
Github user dieb commented on the issue:
https://github.com/apache/commons-lang/pull/309
Should be good now. Thanks!
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/309
[](https://coveralls.io/builds/14329426)
Coverage remained the same at 95.168% when pulling **f00803140ee53875da470a2ffaf5928d66f3f1fb on dieb:dieb/fix-count-cb-bigger-increment** into **6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by dieb <gi...@git.apache.org>.
Github user dieb commented on the issue:
https://github.com/apache/commons-lang/pull/309
Hey @kinow, thank you for reviewing. Can you hold it off for a moment? Just realized the javadoc is incomplete, updating it right now.
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/309
I'll leave the ticket open for a while other to be able to review it too. And before merging I'll have to create a place holder ticket in JIRA. Or if you have time and would like to do that :-) otherwise I'll do as it takes just a couple of minutes to create and link to this PR.
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by dieb <gi...@git.apache.org>.
Github user dieb commented on the issue:
https://github.com/apache/commons-lang/pull/309
Thanks @kinow !
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/309
[](https://coveralls.io/builds/14330917)
Coverage remained the same at 95.168% when pulling **835432cec0687668abe8aedf186e99e414dc20e3 on dieb:dieb/fix-count-cb-bigger-increment** into **6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.
---
[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/309
Ticket created in JIRA https://issues.apache.org/jira/browse/LANG-1370
---