Re: [PR] feat: historical tier aliasing support in coordinator dynamic config (druid)

["jtuglu1 (via GitHub)" <gi...@apache.org>]

jtuglu1 commented on PR #19204:
URL: https://github.com/apache/druid/pull/19204#issuecomment-4240245610

   > nit: should we prevent adding a key in historicalTierAliases that is the name of an actual historical tier? say you have hot_1 and hot_2 actual historical tiers. then say you have: "historicalTierAliases": { "hot_1": ["hot_1", "hot_2"] } and the LoadRule {"hot_1": 2} Now, it's confusing whether we do we load to hot_1 only or both hot_1 and hot_2.
   
   I allowed this primarily for rollback reasons: in case of roll-back, it can work (e.g. your tier originally was hot_1 and you want to make sure on rollback your stuff still works). I think cycle detection is definitely important to add though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org