You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/04/08 01:28:44 UTC

svn commit: r392452 - /jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java

Author: sebb
Date: Fri Apr  7 16:28:43 2006
New Revision: 392452

URL: http://svn.apache.org/viewcvs?rev=392452&view=rev
Log:
Don't save responseData unless it is text

Modified:
    jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java

Modified: jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java?rev=392452&r1=392451&r2=392452&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java Fri Apr  7 16:28:43 2006
@@ -149,19 +149,12 @@
 			SampleSaveConfiguration save) {
 		if (save.saveResponseData(res)) {
 			writer.startNode(TAG_RESPONSE_DATA);
+            writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
 			try {
                 if (SampleResult.TEXT.equals(res.getDataType())){
-    				writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
     				writer.setValue(new String(res.getResponseData(), res.getDataEncoding()));
-                } else {
-                    writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
-                    URL url = res.getURL();
-                    if (url != null) {
-					    writer.setValue(url.toExternalForm());//TODO - better representation
-                    } else {
-                    	writer.setValue("Non-text data, but URL is null");
-                    }
                 }
+                // Otherwise don't save anything - no point
 			} catch (UnsupportedEncodingException e) {
 				writer.setValue("Unsupported encoding in response data, can't record.");
 			}



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org