You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/09 01:02:39 UTC
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17162
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
[client] fix compilation warning in scan_token-test.cc
With the newer gtest library, the INSTANTIATE_TEST_CASE_P macro was
deprecated in favor of INSTANTIATE_TEST_SUITE_P.
This changelist is a follow-up to 074e7e9a0 and doesn't contain
any functional changes.
Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
---
M src/kudu/client/scan_token-test.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/17162/1
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17162
to look at the new patch set (#2).
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
[client] fix compilation warning in scan_token-test.cc
With the newer gtest library, the INSTANTIATE_TEST_CASE_P macro was
deprecated in favor of INSTANTIATE_TEST_SUITE_P.
This changelist is a follow-up to 074e7e9a0 and doesn't contain
any functional changes.
Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
---
M src/kudu/client/scan_token-test.cc
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/17162/2
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17162 )
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Mar 2021 02:41:49 +0000
Gerrit-HasComments: No
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17162 )
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Mar 2021 01:07:25 +0000
Gerrit-HasComments: No
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17162 )
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
[client] fix compilation warning in scan_token-test.cc
With the newer gtest library, the INSTANTIATE_TEST_CASE_P macro was
deprecated in favor of INSTANTIATE_TEST_SUITE_P.
This changelist is a follow-up to 074e7e9a0 and doesn't contain
any functional changes.
Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Reviewed-on: http://gerrit.cloudera.org:8080/17162
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/scan_token-test.cc
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] fix compilation warning in scan token-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17162 )
Change subject: [client] fix compilation warning in scan_token-test.cc
......................................................................
Patch Set 2: Code-Review+2
Carrying over Andrew's and Bankim's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/17162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c6b1d9931b6e9b2543e007a3f0a80b05ff80b4
Gerrit-Change-Number: 17162
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Mar 2021 04:07:05 +0000
Gerrit-HasComments: No