[GitHub] spark pull request #19370: [SPARK-22495] Fix setup of SPARK_HOME variable on...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19370#discussion_r151864995
  
    --- Diff: bin/find-spark-home.cmd ---
    @@ -0,0 +1,49 @@
    +@echo off
    +
    +rem
    +rem Licensed to the Apache Software Foundation (ASF) under one or more
    +rem contributor license agreements.  See the NOTICE file distributed with
    +rem this work for additional information regarding copyright ownership.
    +rem The ASF licenses this file to You under the Apache License, Version 2.0
    +rem (the "License"); you may not use this file except in compliance with
    +rem the License.  You may obtain a copy of the License at
    +rem
    +rem    http://www.apache.org/licenses/LICENSE-2.0
    +rem
    +rem Unless required by applicable law or agreed to in writing, software
    +rem distributed under the License is distributed on an "AS IS" BASIS,
    +rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +rem See the License for the specific language governing permissions and
    +rem limitations under the License.
    +rem
    +
    +rem Path to Python script finding SPARK_HOME
    +set FIND_SPARK_HOME_PYTHON_SCRIPT=%~dp0find_spark_home.py
    +
    +rem Default to standard python interpreter unless told otherwise
    +set PYTHON_RUNNER=python
    +rem If PYSPARK_DRIVER_PYTHON is set, it overwrites the python version
    +if not "x%PYSPARK_DRIVER_PYTHON%" =="x" (
    +  set PYTHON_RUNNER=%PYSPARK_DRIVER_PYTHON%
    +)
    +rem If PYSPARK_PYTHON is set, it overwrites the python version
    +if not "x%PYSPARK_PYTHON%" =="x" (
    --- End diff --
    
    nit `"x%PYSPARK_DRIVER_PYTHON%" =="x"` -> `"x%PYSPARK_DRIVER_PYTHON%"=="x"`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org