You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/11/06 17:16:25 UTC
Review Request 63587: Log Search UI: move top menu down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63587/
-----------------------------------------------------------
Review request for Ambari and Oleg Nechiporenko.
Bugs: AMBARI-22368
https://issues.apache.org/jira/browse/AMBARI-22368
Repository: ambari
Description
-------
Top menu (Undo, Redo, Refresh, History) should be located on one line with tabs, aligned to right. Logout button should remain on its place.
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 37cd869
ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.html PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.spec.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.html a0444c9
ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less 8731582
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html 70150a5
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less 23d5f92
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html 2061582
ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less 2e46213
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html a7858a5
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less 4fe899a
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts 73b6131
ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 150ac56
Diff: https://reviews.apache.org/r/63587/diff/1/
Testing
-------
Executed 109 of 109 SUCCESS (2.729 secs / 2.668 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 63587: Log Search UI: move top menu down
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63587/#review190181
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Ноя. 6, 2017, 5:16 п.п., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63587/
> -----------------------------------------------------------
>
> (Updated Ноя. 6, 2017, 5:16 п.п.)
>
>
> Review request for Ambari and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-22368
> https://issues.apache.org/jira/browse/AMBARI-22368
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Top menu (Undo, Redo, Refresh, History) should be located on one line with tabs, aligned to right. Logout button should remain on its place.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 37cd869
> ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.html PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.spec.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.html a0444c9
> ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less 8731582
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html 70150a5
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less 23d5f92
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html 2061582
> ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less 2e46213
> ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html a7858a5
> ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less 4fe899a
> ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts 73b6131
> ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 150ac56
>
>
> Diff: https://reviews.apache.org/r/63587/diff/1/
>
>
> Testing
> -------
>
> Executed 109 of 109 SUCCESS (2.729 secs / 2.668 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>