You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/06 02:03:56 UTC
[GitHub] [flink] hejiefang opened a new pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
hejiefang opened a new pull request #14566:
URL: https://github.com/apache/flink/pull/14566
[https://issues.apache.org/jira/browse/FLINK-20855](url)
Calculating numBuckets exceeds the maximum value of Int and got a negative number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755028340
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f49a8830122e637223baa49d8a37dfd7e9b8f7dd (Wed Jan 06 02:05:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20855).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11676",
"triggerID" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49a8830122e637223baa49d8a37dfd7e9b8f7dd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11676",
"triggerID" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49a8830122e637223baa49d8a37dfd7e9b8f7dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hejiefang commented on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
hejiefang commented on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035266
OK, I will try that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hejiefang commented on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
hejiefang commented on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035570
>
>
> Could you add a unit test for this?
OK, I will try that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755028340
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f49a8830122e637223baa49d8a37dfd7e9b8f7dd (Fri May 28 09:09:15 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung merged pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
KurtYoung merged pull request #14566:
URL: https://github.com/apache/flink/pull/14566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f49a8830122e637223baa49d8a37dfd7e9b8f7dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49a8830122e637223baa49d8a37dfd7e9b8f7dd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hejiefang removed a comment on pull request #14566: FLINK-20855 Calculating numBuckets exceeds the maximum value of int a…
Posted by GitBox <gi...@apache.org>.
hejiefang removed a comment on pull request #14566:
URL: https://github.com/apache/flink/pull/14566#issuecomment-755035266
OK, I will try that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org