You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 21:16:41 UTC
[GitHub] [airflow] dstandish opened a new pull request #15995: Add flower service annotations in helm chart
dstandish opened a new pull request #15995:
URL: https://github.com/apache/airflow/pull/15995
Annotations are necessary to run flower with a load balancer in a private subnet. Prior to this commit annotations were supported for webserver but not for flower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #15995:
URL: https://github.com/apache/airflow/pull/15995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #15995:
URL: https://github.com/apache/airflow/pull/15995#discussion_r637260878
##########
File path: chart/templates/flower/flower-service.yaml
##########
@@ -33,6 +33,10 @@ metadata:
{{- with .Values.labels }}
{{ toYaml . | indent 4 }}
{{- end }}
+{{- with .Values.flower.service.annotations }}
+ annotations:
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15995:
URL: https://github.com/apache/airflow/pull/15995#issuecomment-846290657
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15995:
URL: https://github.com/apache/airflow/pull/15995#discussion_r637250279
##########
File path: chart/templates/flower/flower-service.yaml
##########
@@ -33,6 +33,10 @@ metadata:
{{- with .Values.labels }}
{{ toYaml . | indent 4 }}
{{- end }}
+{{- with .Values.flower.service.annotations }}
+ annotations:
Review comment:
Can you add a simple test in https://github.com/apache/airflow/blob/master/chart/tests/test_flower.py please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #15995:
URL: https://github.com/apache/airflow/pull/15995#issuecomment-846303806
Ah ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15995: Add flower service annotations in helm chart
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15995:
URL: https://github.com/apache/airflow/pull/15995#issuecomment-846302579
@dstandish Looks like https://github.com/apache/airflow/pull/15972 already covered this and the other case too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org