You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:40:43 UTC

[GitHub] [couchdb] bessbd opened a new pull request #3201: Fix boolean POST to view-like endpoints

bessbd opened a new pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201


   ## Overview
   When using a POST with request body to pass parameters to a view-like request the boolean parameters are accepting only JSON strings, but not booleans. For example the stable parameter works with "true" and "false" but not true and false.
   
   ## Testing recommendations
   
   `mix test --trace test/elixir/test/all_docs_test.exs`
   and
   `mix test --trace test/elixir/test/view_test.exs`
   
   ## Related Issues or Pull Requests
   
   This fixes #3200 .
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` -- N/A
   - [x] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation -- N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201#issuecomment-706381833


   > @bessbd wait, why couldn't you merge it yourself?
   
   @rnewson : because I don't have permissions. I am not an Apache CouchDB committer: https://projects.apache.org/committee.html?couchdb


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201#issuecomment-706140769


   Thank you for the review, @rnewson ! Can you please merge this for me? Also, I'm not sure with the current branching news, which are the branches I should backport this to? I guess, `3.x` for sure. `main`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201#issuecomment-706140769


   Thank you for the review, @rnewson ! Can you please merge this for me? Also, I'm not sure with the current branching news, which are the branches I should backport this to? I guess, `3.x` for sure. `main`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
rnewson commented on pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201#issuecomment-706375240


   hi, yes, please make a PR against main and 3.x too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson merged pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
rnewson merged pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on pull request #3201: Fix boolean POST to view-like endpoints

Posted by GitBox <gi...@apache.org>.
rnewson commented on pull request #3201:
URL: https://github.com/apache/couchdb/pull/3201#issuecomment-706375741


   @bessbd wait, why couldn't you merge it yourself?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org