You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Roshan Naik <ro...@hortonworks.com> on 2013/05/30 21:12:38 UTC
Review Request: Fix for failure in
TestLog.testReplaySucceedsWithUnusedEmptyLogMetaDataFastReplay() in file
channel on Windows:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11544/
-----------------------------------------------------------
Review request for Flume.
Description
-------
ERROR > Unable to delete file:C:\Users\ROSHAN~1\AppData\Local\Temp\1369355138695-0\inflighttakes
In this fix we avoid reusing the checkpoint directory.. and set it up for deletion on jvm exit.
This addresses bug FLUME-2060.
https://issues.apache.org/jira/browse/FLUME-2060
Diffs
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java 6751714
Diff: https://reviews.apache.org/r/11544/diff/
Testing
-------
the said test now passes.
Thanks,
Roshan Naik
Re: Review Request: Fix for failure in
TestLog.testReplaySucceedsWithUnusedEmptyLogMetaDataFastReplay() in file
channel on Windows:
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11544/#review22092
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On May 30, 2013, 7:12 p.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11544/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ERROR > Unable to delete file:C:\Users\ROSHAN~1\AppData\Local\Temp\1369355138695-0\inflighttakes
>
>
> In this fix we avoid reusing the checkpoint directory.. and set it up for deletion on jvm exit.
>
>
> This addresses bug FLUME-2060.
> https://issues.apache.org/jira/browse/FLUME-2060
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java 6751714
>
> Diff: https://reviews.apache.org/r/11544/diff/
>
>
> Testing
> -------
>
> the said test now passes.
>
>
> Thanks,
>
> Roshan Naik
>
>
Re: Review Request: Fix for failure in
TestLog.testReplaySucceedsWithUnusedEmptyLogMetaDataFastReplay() in file
channel on Windows:
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11544/#review21230
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On May 30, 2013, 7:12 p.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11544/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ERROR > Unable to delete file:C:\Users\ROSHAN~1\AppData\Local\Temp\1369355138695-0\inflighttakes
>
>
> In this fix we avoid reusing the checkpoint directory.. and set it up for deletion on jvm exit.
>
>
> This addresses bug FLUME-2060.
> https://issues.apache.org/jira/browse/FLUME-2060
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java 6751714
>
> Diff: https://reviews.apache.org/r/11544/diff/
>
>
> Testing
> -------
>
> the said test now passes.
>
>
> Thanks,
>
> Roshan Naik
>
>