You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Beam JIRA Bot (Jira)" <ji...@apache.org> on 2020/10/12 17:10:01 UTC
[jira] [Commented] (BEAM-10604) Remove "final" modifier from
FileBasedSource#getEstimatedSizeBytes?
[ https://issues.apache.org/jira/browse/BEAM-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212510#comment-17212510 ]
Beam JIRA Bot commented on BEAM-10604:
--------------------------------------
This issue was marked "stale-P2" and has not received a public comment in 14 days. It is now automatically moved to P3. If you are still affected by it, you can comment and move it back to P2.
> Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?
> -------------------------------------------------------------------
>
> Key: BEAM-10604
> URL: https://issues.apache.org/jira/browse/BEAM-10604
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Claire McGinty
> Priority: P3
>
> https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215
> Can we remove the "final" modifier here so subclasses have the option to override? I have a subclass implementation that performs best with a different size estimation heuristic. Similar case with the #split method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)