You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/01 12:19:11 UTC
[GitHub] [airflow] kaxil opened a new pull request #15626: Kubernetes Test Cleanup
kaxil opened a new pull request #15626:
URL: https://github.com/apache/airflow/pull/15626
Some of the tests were redundant in `kubernetes_tests/test_kubernetes_pod_operator_backcompat.py` which didn't test anything related to deprecated classes and were already covered by either `kubernetes_tests/test_kubernetes_pod_operator.py` or `tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15626: Kubernetes Test Cleanup
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15626:
URL: https://github.com/apache/airflow/pull/15626#discussion_r624502415
##########
File path: kubernetes_tests/test_kubernetes_pod_operator_backcompat.py
##########
@@ -153,32 +153,6 @@ def test_image_pull_secrets_correctly_set(self, mock_client, monitor_mock, start
k8s.V1LocalObjectReference(name=fake_pull_secrets)
]
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.start_pod")
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.monitor_pod")
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.delete_pod")
- @mock.patch("airflow.kubernetes.kube_client.get_kube_client")
- def test_pod_delete_even_on_launcher_error(
Review comment:
Does not check anything related to backcompat classes
##########
File path: kubernetes_tests/test_kubernetes_pod_operator_backcompat.py
##########
@@ -651,48 +625,5 @@ def test_init_container(self):
]
assert self.expected_pod == actual_pod
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.start_pod")
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.monitor_pod")
- @mock.patch("airflow.kubernetes.kube_client.get_kube_client")
- def test_pod_priority_class_name(
Review comment:
Does not check anything related to backcompat classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15626: Kubernetes Test Cleanup
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15626:
URL: https://github.com/apache/airflow/pull/15626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15626: Kubernetes Test Cleanup
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15626:
URL: https://github.com/apache/airflow/pull/15626#discussion_r624502340
##########
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##########
@@ -571,34 +571,6 @@ def test_xcom_push(self):
self.expected_pod['spec']['containers'].append(container)
assert self.expected_pod == actual_pod
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.start_pod")
- @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_launcher.PodLauncher.monitor_pod")
- @mock.patch("airflow.kubernetes.kube_client.get_kube_client")
- def test_envs_from_configmaps(self, mock_client, mock_monitor, mock_start):
Review comment:
Moved it to `tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py` since this is a MOCK test just for KPO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15626: Kubernetes Test Cleanup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15626:
URL: https://github.com/apache/airflow/pull/15626#issuecomment-830624397
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org