You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/06/08 18:39:25 UTC
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
pranav.lodha@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18601
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
IMPALA-11121: Support loading testdata in JSON format
This patch supports JSON testdata generation
which will be used for testing the JSON scanner
i.e. IMPALA-10798. E.g. it allows loading JSON
tables with commands like: ./bin/load-data.py -w
functional-query --exploration_strategy=exhaustive
--table_formats=json/none/none. For now, it only
supports 'json/none/none' format.
Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
---
M testdata/bin/generate-schema-statements.py
M tests/common/test_dimensions.py
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/18601/1
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18601 )
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10736/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 19:11:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18601 )
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
IMPALA-11121: Support loading testdata in JSON format
This patch supports JSON testdata generation
which will be used for testing the JSON scanner
i.e. IMPALA-10798. E.g. it allows loading JSON
tables with commands like: ./bin/load-data.py -w
functional-query --exploration_strategy=exhaustive
--table_formats=json/none/none. For now, it only
supports 'json/none/none' format.
Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
---
M testdata/bin/generate-schema-statements.py
M tests/common/test_dimensions.py
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/18601/2
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18601 )
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18601 )
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18601/1/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:
http://gerrit.cloudera.org:8080/#/c/18601/1/tests/common/test_dimensions.py@34
PS1, Line 34: s
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 18:40:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11121: Support loading testdata in JSON format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18601 )
Change subject: IMPALA-11121: Support loading testdata in JSON format
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10735/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cde8c0a2f3121673a66c440482dfde7e7549d8e
Gerrit-Change-Number: 18601
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 19:01:33 +0000
Gerrit-HasComments: No