You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/06 05:32:40 UTC
Review Request 18835: Removed unneeded boost::tuple include
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18835/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp d64e2a4
Diff: https://reviews.apache.org/r/18835/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 18835: Removed unneeded boost::tuple include
Posted by Till Toenshoff <to...@me.com>.
> On March 6, 2014, 5:34 p.m., Ben Mahler wrote:
> > Thanks for following up Till! Can you use the 'Depends On' fields for these reviews?
There was no dependency as far as I saw it - hope I did not miss anything.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18835/#review36369
-----------------------------------------------------------
On March 6, 2014, 4:32 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18835/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 4:32 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp d64e2a4
>
> Diff: https://reviews.apache.org/r/18835/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18835: Removed unneeded boost::tuple include
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18835/#review36369
-----------------------------------------------------------
Ship it!
Thanks for following up Till! Can you use the 'Depends On' fields for these reviews?
- Ben Mahler
On March 6, 2014, 4:32 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18835/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 4:32 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp d64e2a4
>
> Diff: https://reviews.apache.org/r/18835/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18835: Removed unneeded boost::tuple include
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18835/#review36436
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On March 5, 2014, 8:32 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18835/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 8:32 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp d64e2a4
>
> Diff: https://reviews.apache.org/r/18835/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>