You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/19 07:18:03 UTC

[GitHub] [phoenix] virajjasani opened a new pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

virajjasani opened a new pull request #976:
URL: https://github.com/apache/phoenix/pull/976


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 commented on pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #976:
URL: https://github.com/apache/phoenix/pull/976#issuecomment-730831862


   @virajjasani - makes sense. I'll merge this PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 merged pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

Posted by GitBox <gi...@apache.org>.
gjacoby126 merged pull request #976:
URL: https://github.com/apache/phoenix/pull/976


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] virajjasani edited a comment on pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #976:
URL: https://github.com/apache/phoenix/pull/976#issuecomment-730521887


   Thank you @gjacoby126 for the review. 
   Test results for 4.x patch is available on Jira [PHOENIX-6228](https://issues.apache.org/jira/browse/PHOENIX-6228) , whereas test results for master branch might not come until most probably [PHOENIX-6230](https://issues.apache.org/jira/browse/PHOENIX-6230) is fixed because without the fix, github precommit build is timing out apparently: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/view/change-requests/job/PR-976/
   
   I also tried uploading same patch on Jira and awaiting result but I think precommit Jira too will mostly timeout due to PHOENIX-6230. The issue seems with master branch only, 4.x is doing good with `ViewConcurrencyAndFailureIT` test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] virajjasani commented on pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #976:
URL: https://github.com/apache/phoenix/pull/976#issuecomment-730521887


   Thanks you @gjacoby126 for the review. 
   Test results for 4.x patch is available on Jira [PHOENIX-6228](https://issues.apache.org/jira/browse/PHOENIX-6228) , whereas test results for master branch might not come until most probably [PHOENIX-6230](https://issues.apache.org/jira/browse/PHOENIX-6230) is fixed because without the fix, github precommit build is timing out apparently: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/view/change-requests/job/PR-976/
   
   I also tried uploading same patch on Jira and awaiting result but I think precommit Jira too will mostly timeout due to PHOENIX-6230. The issue seems with master branch only, 4.x is doing good with `ViewConcurrencyAndFailureIT` test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 commented on pull request #976: PHOENIX-6228 : Close Admin resources for certain workflows

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #976:
URL: https://github.com/apache/phoenix/pull/976#issuecomment-730515240


   Will merge after we get a test run. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org