You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/27 02:55:32 UTC
[GitHub] [incubator-doris] xuzifu666 opened a new pull request #7490: [Feature] change fix value of disableCache to property
xuzifu666 opened a new pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490
## Proposed changes
Close related #issue (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490#issuecomment-1001634432
hi @xuzifu666 , thanks for your contribution.
I have a question, under what circumstances do we need to set this parameter to false?
Please explain it and update your PR comment.
And you also need to update the document
```
docs/zh-CN/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
docs/en/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
```
to give an example for this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xuzifu666 closed pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
xuzifu666 closed pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xuzifu666 commented on pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490#issuecomment-1001883197
> > hi @xuzifu666 , thanks for your contribution. I have a question, under what circumstances do we need to set this parameter to false? Please explain it and update your PR comment.
> > And you also need to update the document
> > ```
> > docs/zh-CN/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> > docs/en/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > to give an example for this parameter.
> > under multi process circumstances, we need set the parameter to false, avoid delete dir of other user process because the name is same conflict. for a few ago, we just encounter the circumstances. so i commit the pr, but default true to user is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xuzifu666 edited a comment on pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
xuzifu666 edited a comment on pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490#issuecomment-1001883197
> > hi @xuzifu666 , thanks for your contribution. I have a question, under what circumstances do we need to set this parameter to false? Please explain it and update your PR comment.
> > And you also need to update the document
> > ```
> > docs/zh-CN/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> > docs/en/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > to give an example for this parameter.
> > under multi process circumstances, we need set the parameter to false, avoid delete dir of other user process because the name is same conflict. for a few ago, we just encounter the circumstances. so i commit the pr, but default true to user is ok.
https://blog.csdn.net/jyl1798/article/details/42521789 is a factor for the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xuzifu666 commented on pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490#issuecomment-1001883036
> hi @xuzifu666 , thanks for your contribution. I have a question, under what circumstances do we need to set this parameter to false? Please explain it and update your PR comment.
>
> And you also need to update the document
>
> ```
> docs/zh-CN/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> docs/en/sql-reference/sql-statements/Data\ Manipulation/BROKER\ LOAD.md
> ```
>
> to give an example for this parameter.
under multi process circumstances, we need set the parameter to false, avoid delete dir of other user process because the name is same conflict. for a few ago, we just encounter the circumstances. so i commit the pr, but default true to user is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xuzifu666 closed pull request #7490: [Feature] change fix value of disableCache to property
Posted by GitBox <gi...@apache.org>.
xuzifu666 closed pull request #7490:
URL: https://github.com/apache/incubator-doris/pull/7490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org