You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/12 18:51:46 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
SolidWallOfCode opened a new pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596
@bneradt noticed a problem reported by clang analyzer and asked me about it. In tracking it down and trying to understand what the code was doing, I noticed it didn't seem to ever be invoked. The result is this PR which removes the method, `UnixNetVConnection::startEvent` that contains the problematic code, thus resolving the clang analyzer issue.
AFAICT `startEvent` was previously used as initialization for the net threads, but after the restructuring of that a few years back it became dead code. Such initialization is handled via the `EThread::schedule_spawn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596#issuecomment-798787034
This patch addresses an issue raised by clang-analyzer 11.1.0. This will therefore be needed across our supported branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596#issuecomment-799718240
OK, let me fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596#issuecomment-887892096
@bneradt What was the original issue which the clang-analyzer reported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596#issuecomment-800485613
Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7596: Remove UnixNetVConnection::startEvent - not actually called.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7596:
URL: https://github.com/apache/trafficserver/pull/7596#issuecomment-801237817
Removing the 8.1.x project from this PR since I created a separate PR that cherry-picks this to 8.1.x:
https://github.com/apache/trafficserver/pull/7609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org