You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/07/09 19:25:37 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #32467: Fix async KPO by waiting pod termination in `execute_complete` before cleanup
hussein-awala opened a new pull request, #32467:
URL: https://github.com/apache/airflow/pull/32467
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #32458
related: #31348
related: #31335
This PR reverts #31348 which doesn't handle the case where `do_xcom_push` is True, and move the waiting strategy to `execute_complete` in order to wait pod termination before calling the cleanup method.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix async KPO by waiting pod termination in `execute_complete` before cleanup [airflow]
Posted by "apilaskowski (via GitHub)" <gi...@apache.org>.
apilaskowski commented on PR #32467:
URL: https://github.com/apache/airflow/pull/32467#issuecomment-1802097193
@hussein-awala Was this introduced back? Or is this termination problem still happening in newest versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix async KPO by waiting pod termination in `execute_complete` before cleanup [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #32467:
URL: https://github.com/apache/airflow/pull/32467#issuecomment-1802741506
> Was this introduced back? Or is this termination problem still happening in newest versions?
The fix was released in cncf.kubernetes 7.3.0 ([changelog](https://airflow.apache.org/docs/apache-airflow-providers-cncf-kubernetes/stable/changelog.html#id23)), are you facing the same problem in a newer version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix async KPO by waiting pod termination in `execute_complete` before cleanup [airflow]
Posted by "apilaskowski (via GitHub)" <gi...@apache.org>.
apilaskowski commented on PR #32467:
URL: https://github.com/apache/airflow/pull/32467#issuecomment-1803457241
In our case we didn't use `do_xcom_push`, so it wasn't a problem for us.
We were wondering, if it might be reimplemented to include changes from https://github.com/apache/airflow/pull/31348 properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #32467: Fix async KPO by waiting pod termination in `execute_complete` before cleanup
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #32467:
URL: https://github.com/apache/airflow/pull/32467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix async KPO by waiting pod termination in `execute_complete` before cleanup [airflow]
Posted by "apilaskowski (via GitHub)" <gi...@apache.org>.
apilaskowski commented on PR #32467:
URL: https://github.com/apache/airflow/pull/32467#issuecomment-1803435467
I meant the opposite.
In 7.2.0 KPO works fine, but in 7.3.0 it is not.
We suspect that this is due to removing following part of code:
```
if pod_status not in PodPhase.terminal_states:
self.log.info(
"Pod %s is still running. Sleeping for %s seconds.",
self.pod_name,
self.poll_interval,
)
await asyncio.sleep(self.poll_interval)
```
How do you feel, can this be reintroduced? Or was this solved in never version differently?
When we had high load of KPO they started to fail from Airflow perspective, while those pods were started properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org