You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2019/06/05 07:30:00 UTC

[jira] [Created] (WICKET-6673) PriorityHeaderItem ordering is wrong for siblings

Sven Meier created WICKET-6673:
----------------------------------

             Summary: PriorityHeaderItem ordering is wrong for siblings
                 Key: WICKET-6673
                 URL: https://issues.apache.org/jira/browse/WICKET-6673
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 9
            Reporter: Sven Meier
            Assignee: Sven Meier


PriorityHeaderItems allows parents to move their header items infront of those of their children (_parent-first_ instead of _child-first_).

But the current implemention sorts PriorityHeaderItems of siblings in reverse order, e.g. having a component hierarchy as follows:
{code:java}
Component A
+- Component AA
+- Component AB
{code}
... the PriorityHeaderItems of all these components are sorted as:
{code:java}
- PriorityHeaderItem of A
- PriorityHeaderItem of AB
- PriorityHeaderItem of AA
{code}
Why should the PriorityHeaderItem of component AB be before that of AA? This isn't _parent-first_, it is _reverse-order_.

IMHO a more suitable ordering would be "_parent-first-preserving-siblings"_:
{code:java}
- PriorityHeaderItem of A
- PriorityHeaderItem of AA
- PriorityHeaderItem of AB
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)